Swarming: Fix double base64 encoding of secret_bytes in swarming tasks#5249
Open
Swarming: Fix double base64 encoding of secret_bytes in swarming tasks#5249
Conversation
IvanBM18
added
the
swarming
jardondiego
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This small Pr fixes a misconception we had since the beginning, we were manually encoding the
input_dowload_urlto then give it to thesecret_bytesat the swarming request, which in paper is correct. BUT the swarming request proto implicitly encodes the given bytes, hence we were encoding them twice.So we remove the additional encoding from the request.
Test performed
This changes have been present in
devsince April 16thWe are able to successfully download the input using the signed url.